Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning policy #148

Merged
merged 4 commits into from
Mar 10, 2019
Merged

Versioning policy #148

merged 4 commits into from
Mar 10, 2019

Conversation

elainemattos
Copy link
Contributor

Olá pessoal,

Segue PR da tradução de Versioning Policy, adaptei alguns termos porém não tenho certeza se os mesmos estão adequados, sendo eles:

  • breaking changes - atualização que quebra compatibilidade
  • Warnings - advertência.

Obrigada!

@netlify
Copy link

netlify bot commented Mar 7, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 861bdbb

https://deploy-preview-148--pt-br-reactjs.netlify.com

@juunegreiros juunegreiros mentioned this pull request Mar 7, 2019
Closed
13 tasks
@jhonmike jhonmike added the needs review A pull request ready to be reviewed label Mar 7, 2019
@tesseralis tesseralis mentioned this pull request Mar 7, 2019
Closed
90 tasks
Luanf
Luanf suggested changes Mar 7, 2019
View reviewed changes
lucianomlima
lucianomlima reviewed Mar 7, 2019
View reviewed changes
@jhonmike jhonmike added the needs author response Changes requested needing author's input label Mar 8, 2019
jhonmike
jhonmike requested changes Mar 8, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ficou um pouco complicado fazer a review, pois por falta de alguns espaçamentos citados pelo @lucianomlima a diff ficou toda bagunçada, aproveitei e coloquei sugestões dos espaçamentos, espero que facilite :D

@glaucia86
Copy link
Member

@elainemattos só faça as alterações que o @jhonmike sugeriu para que possamos aprovar a sua excelente contribuição! :)

glaucia86
glaucia86 reviewed Mar 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elainemattos conforme comentado, faça as alterações sugeridas pelo @jhonmike para que possamos aprovar a sua excelente contribuição! :)

lucianomlima
lucianomlima previously approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@lucianomlima lucianomlima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fora pequenas correções, LGTM!

@jhonmike jhonmike removed the needs review A pull request ready to be reviewed label Mar 9, 2019
@jhonmike jhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Mar 9, 2019
@lucianomlima
Copy link
Contributor

👏🏼👏🏼👏🏼 Good job!

glaucia86
glaucia86 approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86
Copy link
Member

bitmoji

@elainemattos muito obrigada pela sua excelente contribuição. Estou aprovando e fazendo merge agora! Mais uma vez, muito obrigada!

@glaucia86 glaucia86 merged commit ff47781 into reactjs:master Mar 10, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luanf Luanf Luanf requested changes

@glaucia86 glaucia86 glaucia86 approved these changes

@jhonmike jhonmike jhonmike approved these changes

@lucianomlima lucianomlima lucianomlima left review comments

Assignees

@jhonmike jhonmike

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elainemattos @glaucia86 @lucianomlima @jhonmike @Luanf